Fix code smell issues

1. Remove unused empty function WorkloadHandler#List 2. Reduce Cognitive Complexity of ProviderHandler#ListContent Signed-off-by: Arik Hadas <[email protected]>
kubev2v · Jul 23, 2023 · 3f2bcd5 · 3f2bcd5
1 parent 88c167f
commit 3f2bcd5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/pkg/controller/provider/web/ova/workload.go b/pkg/controller/provider/web/ova/workload.go
@@ -23,17 +23,11 @@ type WorkloadHandler struct {
 }
 
 // Add routes to the `gin` router.
-// no-op
 func (h *WorkloadHandler) AddRoutes(e *gin.Engine) {
 	e.GET(WorkloadRoot, h.Get)
 }
 
-// List resources in a REST collection.
-func (h WorkloadHandler) List(ctx *gin.Context) {
-}
-
 // Get a specific REST resource.
-// no-op
 func (h WorkloadHandler) Get(ctx *gin.Context) {
 	status, err := h.Prepare(ctx)
 	if status != http.StatusOK {

diff --git a/pkg/controller/provider/web/ovirt/provider.go b/pkg/controller/provider/web/ovirt/provider.go
@@ -95,10 +95,7 @@ func (h *ProviderHandler) ListContent(ctx *gin.Context) (content []interface{},
 	ns := q.Get(base.NsParam)
 	for _, collector := range list {
 		if p, cast := collector.Owner().(*api.Provider); cast {
-			if p.Type() != api.OVirt {
-				continue
-			}
-			if ns != "" && ns != p.Namespace {
+			if p.Type() != api.OVirt || (ns != "" && ns != p.Namespace) {
 				continue
 			}
 			if collector, found := h.Container.Get(p); found {