Backport changes to 2.7 #1090
Merged
Backport changes to 2.7 #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: When running the warm migration with VMs more than the MaxInFlight disks. The VMs over this number won't start the migration till the cutover. Once the cutover is started the VMs which were not started migrate same as in the old migration. So there is larger downtime. Fix: Ignore the cost when in `CopyingPaused`, this allows the other Migrations to start as the cost is reduced when the VM disk transfer is finished. Note: This patch also improves the cold migration as it ignores the count when creating the VM so the other VM migrations can get started. And dramaticially improves the warm migration time as we are not waiting for the guest conversion as we already have the disk so we start the guest conversion and do not halt the scheduler. Fixes: https://issues.redhat.com/browse/MTV-1543 Signed-off-by: Martin Necas <[email protected]>
Issue: When migrating the VM using the warm migration with more disks than the MAX_VM_INFLIGHT the VM won't get scheduled and won't start the migration. Fix: Once the scheduler is empty the controller will start the migration of the large VMs. Fixes: https://issues.redhat.com/browse/MTV-1573 Signed-off-by: Martin Necas <[email protected]>
Issue: When we start the warm migration with VM which has a lot of disks we wait for the whole VM to get migrated. We do not ignore the disks that has been already migrated. This can cause that when we have 2 VMs with 10 disks each and on each there is one larger disk the whole scheduler will be halted untill they finish. So even if the left 9 disks will be done no migration will be started. Fix: Subtract the finished disks from the disk count. Fixes: https://issues.redhat.com/browse/MTV-1537 Signed-off-by: Martin Necas <[email protected]>
Issue: The MTV specifies the `-on` argument in the wrong place /usr/bin/virt-v2v [...] -- epassaroMigrate-2 -on epassaromigrate-2 Fix: /usr/bin/virt-v2v [...] -on newname -- oldname Signed-off-by: Martin Necas <[email protected]>
Issue: When the virt-v2v pod fails the plan does not fail. Signed-off-by: Martin Necas <[email protected]>
Related to: kubev2v#1085 Fixes: https://issues.redhat.com/browse/MTV-1569 Signed-off-by: Martin Necas <[email protected]>
|
yaacov
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport: