Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monitor resources creation to forklift operator #947

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Add monitor resources creation to forklift operator #947

merged 1 commit into from
Jul 1, 2024

Conversation

bkhizgiy
Copy link
Member

@bkhizgiy bkhizgiy commented Jul 1, 2024

Backport #932

@bkhizgiy bkhizgiy requested review from ahadas and removed request for ahadas July 1, 2024 14:03
ahadas
ahadas reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkhizgiy how come that this PR doesn't contain all the changes of the PR for the main branch?

@bkhizgiy
Copy link
Member Author

bkhizgiy commented Jul 1, 2024

Only the go related staff, I've run the same command on both but on this one there wasn't any changes.
I used go mod tidy and then go mod vendor and bazel generate.
maybe on main we had some leftovers from the modules I've added and then removed.

@ahadas ahadas merged commit b3fee61 into kubev2v:release-v2.6.3 Jul 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas ahadas left review comments

@bennyz bennyz Awaiting requested review from bennyz bennyz is a code owner

@liranr23 liranr23 Awaiting requested review from liranr23 liranr23 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkhizgiy @ahadas