Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tf_validation_backend tool to the hack dir #281

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

loheagn
Copy link
Contributor

@loheagn loheagn commented Mar 16, 2022

Add a hack tool which shows how to fetch the backend block from a Terraform configuration file.

This pr updates #111 and #239 .

Signed-off-by: loheagn [email protected]

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #281 (7810dc2) into master (69baabd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   75.30%   75.30%           
=======================================
  Files          19       19           
  Lines        1223     1223           
=======================================
  Hits          921      921           
  Misses        236      236           
  Partials       66       66           
Flag Coverage Δ
unit 75.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69baabd...7810dc2. Read the comment docs.

@@ -0,0 +1,24 @@
# tf_validation_backend
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does validation mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validation means that if the backend block is invalid, the tool will report an error.
emmm, maybe it woudl be better to use fetch?

Copy link
Collaborator

@zzxwill zzxwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please support accepting a folder that stores some .tf files besides a .tf file in next PR.

@zzxwill zzxwill merged commit 9bdd567 into kubevela:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants