Support creating multi-arch images #125
Conversation
kubevirt-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Remove the verbose build to reduce output lines Print the build platform drop the redundent chmod command. go build creates runnable binaries. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Allow building multi-arch images. The user can now use the `--platform` command line parameter, to build different platform. The builder image runs on the local machine platform, to acheive better performance, But the final image is build according to the user request. Bump go to 1.23 The final image does not need go. replace it's base image to plain alpine, instead of golang alpine. re-order the Dockerfile commands to get better caching, and fewer new layers when storing the image in the registry. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Also, add the `push-multi-arch` make target to run the script. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
nunnatsa
force-pushed
the
multi-arch-images
branch
from
4156400 to
6646f34
Compare
kubevirt-bot
added
dco-signoff: yes
nunnatsa
force-pushed
the
multi-arch-images
branch
2 times, most recently
from
c927745 to
4e33703
Compare
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
nunnatsa
force-pushed
the
multi-arch-images
branch
from
4e33703 to
3771faa
Compare
|
@nunnatsa: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
This PR modifies the Dockerfiles and some other scripts, to allow creating multi-arch docker images.
It also added the new
push-multi-archmake target, to create and push all the images as multi-arch manifests, for:This new make target can replace the existing
pushin two place in https://github.com/kubevirt/project-infra/blob/14a04add9bc136d08d07d80a31233a8f47f3e60b/github/ci/prow-deploy/files/jobs/kubevirt/application-aware-quota/application-aware-quota-postsubmits.yamlRelease note: