Skip to content

Commit

Permalink
sigs-validator: add unit tests
Browse files Browse the repository at this point in the history
Adds unit tests for sig validation as precondition of refactoring.

Signed-off-by: Daniel Hiller <[email protected]>
  • Loading branch information
dhiller committed Dec 11, 2024
1 parent c4fd8a0 commit fc0631f
Show file tree
Hide file tree
Showing 4 changed files with 464 additions and 1 deletion.
2 changes: 1 addition & 1 deletion validators/cmd/sigs/sigs-validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ func validateSubprojects(groupToValidate *sigs.Group, groupLog *log.Entry, kubev
}

func validateOwnersReferences(subProject *sigs.SubProject, subprojectLog *log.Entry) []string {
foundOwners := make([]string, 0)
var foundOwners []string
for _, ownersFileURL := range subProject.Owners {
response, err := http.DefaultClient.Head(ownersFileURL)
if err != nil {
Expand Down
Loading

0 comments on commit fc0631f

Please sign in to comment.