Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design-proposal: instancetype.kubevirt.io - pkg/instancetype refactor #323

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lyarwood
Copy link
Member

What this PR does / why we need it:

This isn't required at all but I wanted to write down how I think we should go about refactoring the package.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

@kubevirt-bot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 11, 2024
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vladikr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lyarwood lyarwood changed the title WIP instancetype.kubevirt.io - pkg/instancetype refactor WIP design-proposal: instancetype.kubevirt.io - pkg/instancetype refactor Sep 11, 2024
@lyarwood lyarwood force-pushed the instancetype-refactor branch 3 times, most recently from ca8d5a6 to 1cb3625 Compare September 12, 2024 08:33
@lyarwood
Copy link
Member Author

/cc @0xFelix
/cc @akrejcir

If you have time this week would you mind giving this a once over? Writing this effort up as a design proposal is a little over the top but I thought it would be easier to discuss now instead of later in a huge PR reworking everything.

This isn't required at all but I wanted to write down how I think we
should go about refactoring the package.

Signed-off-by: Lee Yarwood <[email protected]>
@akrejcir
Copy link

Looks good, thanks for the changes.

@lyarwood lyarwood changed the title WIP design-proposal: instancetype.kubevirt.io - pkg/instancetype refactor design-proposal: instancetype.kubevirt.io - pkg/instancetype refactor Sep 23, 2024
@lyarwood lyarwood marked this pull request as ready for review September 23, 2024 16:19
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants