Skip to content

Commit

Permalink
webhooks/datavolume: comment about remove check of claim adoption (#3481
Browse files Browse the repository at this point in the history
)

There is an open issue in github to remove the claim
adoption feature gate:
#3480
Once the FG is removed we should remove the check in the webhook
that verifies if it allowed to have an existing PVC.

Signed-off-by: Shelly Kagan <[email protected]>
  • Loading branch information
ShellyKa13 authored Oct 28, 2024
1 parent 75f00e2 commit 495b44a
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/apiserver/webhooks/datavolume-validate.go
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,9 @@ func (wh *dataVolumeValidatingWebhook) Admit(ar admissionv1.AdmissionReview) *ad
return toAdmissionResponseError(err)
}
} else {
// We are planning to remove the Claim adoption feature gate
// https://github.com/kubevirt/containerized-data-importer/issues/3480
// once removed we should remove the check for it in this webhook.
allow, err := cc.ClaimMayExistBeforeDataVolume(wh.controllerRuntimeClient, pvc, &dv)
if err != nil {
return toAdmissionResponseError(err)
Expand Down

0 comments on commit 495b44a

Please sign in to comment.