Watch for ResourceQuota updates to reconcile DVs #3601
Conversation
Pending DataVolumes which failed to create PVC due to exceeded quota in the namespace, were not reconciled even if the ResourceQuota was increased or deleted. Signed-off-by: Arnon Gilboa <[email protected]>
kubevirt-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -335,6 +335,28 @@ func addDataVolumeControllerCommonWatches(mgr manager.Manager, dataVolumeControl | |||
| } | |||
| } | |||
|
|
|||
| // Watch for ResourceQuota updates to reconcile the pending DVs which exceeded the quota | |||
| if err := dataVolumeController.Watch(source.Kind(mgr.GetCache(), &corev1.ResourceQuota{}, handler.TypedEnqueueRequestsFromMapFunc[*corev1.ResourceQuota]( | |||
| func(ctx context.Context, rq *corev1.ResourceQuota) []reconcile.Request { | |||
There was a problem hiding this comment.
I wish the PVCs got created and just not bind instead of us having to watch this resource
Since it's a bit out of scope for CDI to know about these
With that said, I think these are not large like configmaps so it might be fine
@mhenriks WDYT?
There was a problem hiding this comment.
I wish the PVCs got created and just not bind instead of us having to watch this resource
I totally agree, but unfortunately that's not the current k8s behavior. It rejects such PVC creation in the admission control phase of the API server.
There was a problem hiding this comment.
Yeah I'm just not sure we want to be the first/only controller to watch those
There was a problem hiding this comment.
Here's the github query I could come up - https://github.com/search?q=%2F%5C.Watch.*%5C.ResourceQuota%5C%7B%2F&type=code
|
/retest |
What this PR does / why we need it:
Pending
DataVolumeswhich failed to createPVCdue to exceeded quota in the namespace, were not reconciled even if theResourceQuotawas increased or deleted.Which issue(s) this PR fixes:
Fixes #
Release note: