Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move migration lane to 1.32 Kubernetes #4000

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xpivarc
Copy link
Member

@xpivarc xpivarc commented Mar 5, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Mar 5, 2025
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@brianmcarey
Copy link
Member

/rehearse

Should this be applied for v1.5 too?

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.32-sig-compute-migrations

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@xpivarc
Copy link
Member Author

xpivarc commented Mar 5, 2025

/rehearse

Should this be applied for v1.5 too?

Most likely yes

Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Can you bump the periodic lane as well please?

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2025
@brianmcarey
Copy link
Member

brianmcarey commented Mar 6, 2025

@dhiller will this cause the status-reconciler to trigger hundreds of new migrations jobs? maybe we will have to scale it down and migrate the status of the jobs?

- presubmit
- periodic
- 1.5 presubmit

Signed-off-by: Luboslav Pivarc <[email protected]>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2025
@kubevirt-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@xpivarc
Copy link
Member Author

xpivarc commented Mar 6, 2025

Updated to cover presubmit + 1.5 + periodic

@dhiller
Copy link
Contributor

dhiller commented Mar 6, 2025

@dhiller will this cause the status-reconciler to trigger hundreds of new migrations jobs? maybe we will have to scale it down and migrate the status of the jobs?

Yes - additionally the migrations lane seems to appear flaky, which will make the situation even worse I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants