-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move migration lane to 1.32 Kubernetes #4000
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhiller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/rehearse Should this be applied for v1.5 too? |
Rehearsal jobs created for this PR:
You can trigger rehearsal for all jobs by commenting either For a specific PR you can comment For a list of jobs that you can rehearse you can comment |
Most likely yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Can you bump the periodic lane as well please?
@dhiller will this cause the status-reconciler to trigger hundreds of new migrations jobs? maybe we will have to scale it down and migrate the status of the jobs? |
- presubmit - periodic - 1.5 presubmit Signed-off-by: Luboslav Pivarc <[email protected]>
New changes are detected. LGTM label has been removed. |
Updated to cover presubmit + 1.5 + periodic |
Yes - additionally the migrations lane seems to appear flaky, which will make the situation even worse I believe. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: