-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PolicyServer PodDisruptionBudget documentation. #386
Conversation
✅ Deploy Preview for silly-bunny-8cedd0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@jvanz I see no changes in src. This is only doc change and how are you expecting people to add this to their kubewarden-controller helm chart ? |
There are a bunch of PR changing the controller and the Helm charts: https://github.com/kubewarden/helm-charts/pull/414/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions.
@jvanz don't you have to add it to the sidebar too? |
It's already in the sidebar |
Add documentation to describe the `minAvailable` and `maxUnavailable` fields in the policy server spec. Signed-off-by: José Guilherme Vanz <[email protected]>
Hi @flavio, the big reorg a while back got rid of all that mess. The structure is defined in the file system, just put a new doc in the right place, make sure the title, sidebar_title and possibly sidebar_position are as needed in the front matter, sidebar get's auto generated and Bob's your uncle, easy peasy, etc. https://en.wikipedia.org/wiki/Bob%27s_your_uncle. I may have neglected to emphasize this detail at the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny typo in the front matter but lgtm
Co-authored-by: John Krug <[email protected]> Signed-off-by: Flavio Castelli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@jhkrug thanks for having introduced me to "bob is your uncle" 😄
Description
Add documentation to describe the
minAvailable
andmaxUnavailable
fields in the policy server spec.Fix kubewarden/kubewarden-controller#692