Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PolicyServer PodDisruptionBudget documentation. #386

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

jvanz
Copy link
Member

@jvanz jvanz commented Mar 27, 2024

Description

Add documentation to describe the minAvailable and maxUnavailable fields in the policy server spec.

Fix kubewarden/kubewarden-controller#692

@jvanz jvanz self-assigned this Mar 27, 2024
@jvanz jvanz requested a review from a team as a code owner March 27, 2024 19:49
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for silly-bunny-8cedd0 ready!

Name Link
🔨 Latest commit 155ebcf
🔍 Latest deploy log https://app.netlify.com/sites/silly-bunny-8cedd0/deploys/6613c065a3e5d900086dc3f2
😎 Deploy Preview https://deploy-preview-386--silly-bunny-8cedd0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ferhatguneri
Copy link

@jvanz I see no changes in src. This is only doc change and how are you expecting people to add this to their kubewarden-controller helm chart ?

@jvanz
Copy link
Member Author

jvanz commented Apr 2, 2024

@jvanz I see no changes in src. This is only doc change and how are you expecting people to add this to their kubewarden-controller helm chart ?

There are a bunch of PR changing the controller and the Helm charts:

https://github.com/kubewarden/helm-charts/pull/414/files
kubewarden/kubewarden-controller#698

Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

@flavio
Copy link
Member

flavio commented Apr 2, 2024

@jvanz don't you have to add it to the sidebar too?

@jvanz
Copy link
Member Author

jvanz commented Apr 3, 2024

@jvanz don't you have to add it to the sidebar too?

It's already in the sidebar

image

Add documentation to describe the `minAvailable` and `maxUnavailable`
fields in the policy server spec.

Signed-off-by: José Guilherme Vanz <[email protected]>
@jhkrug
Copy link
Contributor

jhkrug commented Apr 4, 2024

@jvanz don't you have to add it to the sidebar too?

Hi @flavio, the big reorg a while back got rid of all that mess. The structure is defined in the file system, just put a new doc in the right place, make sure the title, sidebar_title and possibly sidebar_position are as needed in the front matter, sidebar get's auto generated and Bob's your uncle, easy peasy, etc. https://en.wikipedia.org/wiki/Bob%27s_your_uncle. I may have neglected to emphasize this detail at the time.

Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typo in the front matter but lgtm

docs/howtos/policy-servers/03-pod-disruption-budget.md Outdated Show resolved Hide resolved
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jhkrug thanks for having introduced me to "bob is your uncle" 😄

@fabriziosestito fabriziosestito merged commit d2feb6e into kubewarden:main Apr 8, 2024
6 checks passed
@jvanz jvanz deleted the pod-pdb branch April 9, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: allow PolicyServer to have Pod disruption budget
5 participants