fix: handle enable monitoring boolean flag #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change has been done to policy-server. Starting from the v1.11 release, the boolean flags must take either `true` or `false` as values when they are toggled via environment variables. Prior to that, any kind of value was fine. Signed-off-by: Flavio Castelli <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
===========================================
+ Coverage 42.17% 69.45% +27.28%
===========================================
Files 23 5 -18
Lines 2006 478 -1528
===========================================
- Hits 846 332 -514
+ Misses 1085 100 -985
+ Partials 75 46 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvanz
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change has been done to policy-server. Starting from the v1.11 release, the boolean flags must take either
trueorfalseas values when they are toggled via environment variables.Prior to that, any kind of value was fine.