Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump dependencies, docker #697

Closed
wants to merge 3 commits into from
Closed

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Mar 27, 2024

Description

  • Bump deps go get -u && go mod tidy: bump client-go patch release
  • Manually bump docker to v0.26, to consume fix to CVE-2024-29018. We aren't vulnerable as this is a dev dependency.

Test

CI

Additional Information

Head of this branch is before anti-affinity work, PR can be rebased or reopened against a feature 1.11-patch branch.

Tradeoff

Potential improvement

Removes image scanning vulnv, even if the docker dep is only a dev
dep.

Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
@viccuad viccuad self-assigned this Mar 27, 2024
@viccuad viccuad requested a review from a team as a code owner March 27, 2024 09:58
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.76%. Comparing base (faca8b6) to head (577a051).

❗ Current head 577a051 differs from pull request most recent head 0954619. Consider uploading reports for the commit 0954619 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
+ Coverage   50.15%   50.76%   +0.60%     
==========================================
  Files          26       26              
  Lines        1970     1970              
==========================================
+ Hits          988     1000      +12     
+ Misses        878      868      -10     
+ Partials      104      102       -2     
Flag Coverage Δ
integration-tests 71.12% <ø> (+2.51%) ⬆️
unit-tests 44.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viccuad viccuad added this to the 1.11-patch milestone Mar 27, 2024
@viccuad
Copy link
Member Author

viccuad commented Mar 27, 2024

Reopening against branch release-1.11.1

@viccuad viccuad closed this Mar 27, 2024
@viccuad viccuad removed this from the 1.11-patch milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants