refactor: remove easyjson #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
fabriziosestito
force-pushed
the
refactor/remove-easyjson
branch
from
1d8f243
to
7031318
Compare
viccuad
reviewed
Aug 1, 2023
viccuad
approved these changes
Aug 1, 2023
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
fabriziosestito
force-pushed
the
refactor/remove-easyjson
branch
from
f0fc519
to
58c6dea
Compare
flavio
approved these changes
Aug 1, 2023
jvanz
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the easyjson dependency by bumping
policy-sdkto the latest version.Also, bumps
reusable-test-policy-goaction to the latest version.Test
Existing tests should pass.
Additional Information
The refactor was very similar to: kubewarden/safe-labels-policy#34
I had to introduce the exact same newtype approach used in
safe-label-policyby wrapping the regexp in a struct to simplify marshaling and unmarshaling operations.I realized the code can be simplified, so I will backport the modifications to
safe-labels-policyas well.