Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pre-factor code related to junit reporting #580

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

porridge
Copy link
Member

@porridge porridge commented Nov 25, 2024

What this PR does / why we need it:

This is preparation for changes needed to solve #575 .

There are no significant changes to functionality. See the individual commits, which:

  1. change the report ordering to be stable (name-based) - this makes the subsequent test simple. I was somewhat surprised that the top-level (suite) order can differ, even though it's not executed in parallel. I don't think this is due to concurrency, but I'm adding a mutex just in case.
  2. add a dummy test suite and golden files to prevent unintended changes to the reports
  3. introduce an abstraction for reporting, that in a future PR will internally be creating the report slightly differently, based on a configuration setting

@porridge porridge requested a review from mclasmeier November 25, 2024 15:32
@porridge porridge requested a review from kensipe as a code owner November 25, 2024 15:32
@porridge porridge marked this pull request as draft November 25, 2024 15:34
@porridge porridge force-pushed the porridge/junit-granularity-prefactoring branch 3 times, most recently from cf7cc7a to dd39bb2 Compare November 26, 2024 07:42
Signed-off-by: Marcin Owsiany <[email protected]>
@porridge porridge force-pushed the porridge/junit-granularity-prefactoring branch 2 times, most recently from b127f74 to 6e8425b Compare November 26, 2024 07:48
@porridge porridge marked this pull request as ready for review November 26, 2024 07:51
@porridge porridge requested a review from vladbologa November 26, 2024 07:51
Signed-off-by: Marcin Owsiany <[email protected]>
Signed-off-by: Marcin Owsiany <[email protected]>
@porridge porridge force-pushed the porridge/junit-granularity-prefactoring branch from 6e8425b to f8e1d9a Compare November 28, 2024 05:33
@porridge porridge merged commit 6989c98 into main Nov 28, 2024
6 checks passed
@porridge porridge deleted the porridge/junit-granularity-prefactoring branch November 28, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants