Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support exported bash functions #18

Merged
merged 3 commits into from
Aug 15, 2020
Merged

Support exported bash functions #18

merged 3 commits into from
Aug 15, 2020

Conversation

xmik
Copy link
Member

@xmik xmik commented Aug 13, 2020

Please read the changelog entry for version: 0.9.0
This should fix the issue: #17

tomzo
tomzo requested changes Aug 14, 2020
View reviewed changes
Copy link
Member

@tomzo tomzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. As discussed, for clarity, please

  • move the problem description from changelog to the issue
  • add a section in the readme about bash functions being not preserved and how to preserve them

@xmik
Copy link
Member Author

xmik commented Aug 14, 2020

@tomzo, thanks for reviewing. I incorporated your remarks.

@xmik xmik merged commit 0f9b9f6 into master Aug 15, 2020
@xmik xmik deleted the bash-functions branch February 4, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomzo tomzo tomzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xmik @tomzo