chore: AppHeader/mobile の内部処理を整理する vol.1 #5392
Open
+171
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-refactoring-AppHeader
…e-refactoring-AppHeader
…e-refactoring-AppHeader
yagimushi
force-pushed
the
chore-refactoring-AppHeader-mobile
branch
2 times, most recently
from
1196c3d to
6a186de
Compare
yagimushi
force-pushed
the
chore-refactoring-AppHeader-mobile
branch
from
6a186de to
032a8d2
Compare
commit: |
…e-refactoring-AppHeader-mobile
AtsushiM
commented
Feb 25, 2025
| }) | ||
| } | ||
|
|
||
| const looseSearchQuery = normalize(searchQuery) |
There was a problem hiding this comment.
normalizeは1文字ずつ変換処理を行うため、かなり重い処理になります。
元々のロジックではlooseIncludeで毎回変換が行われていたため事前に変換処理を行います
AtsushiM
commented
Feb 25, 2025
Comment on lines
14
to
18
| if (firstName && lastName) { | ||
| return `${lastName} ${firstName}${empCode ? `（${empCode}）` : ''}` | ||
| } | ||
|
|
||
| return ( | ||
| (firstName && lastName ? `${lastName} ${firstName}` + empCodeStr : empCode ? empCode : email) ?? | ||
| '' | ||
| ) | ||
| return empCode || email || '' |
There was a problem hiding this comment.
元のロジックでは不必要なempCodeStrが生成される場合があったため、条件分岐で整理しています
AtsushiM
requested review from
misako0927 and
nabeliwo
and removed request for
a team
…e-refactoring-AppHeader-mobile
nabeliwo
reviewed
Mar 6, 2025
Comment on lines
+16
to
+20
| const Header = isDesktop ? DesktopHeader : MobileHeader | ||
|
|
||
| return ( | ||
| <LocaleContextProvider locale={locale}> | ||
| <DesktopHeader {...props}>{isDesktop && children}</DesktopHeader> | ||
| <MobileHeader {...props}>{isMobile && children}</MobileHeader> | ||
| <Header {...props}>{children}</Header> |
There was a problem hiding this comment.
上記 is
smarthr-ui/packages/smarthr-ui/src/components/AppHeader/AppHeader.tsx
Lines 12 to 14 in b5b23f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法