Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(checklinks): exclude external website from checklinks #2116

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Icarus9913
Copy link
Contributor

I got some checklinks failure but it did works from my PC:

https://deploy-preview-2114--kuma.netlify.app/docs/2.9.x/production/dp-config/cni/
	403	https://docs.cilium.io/en/v1.14/operations/upgrade/#id2
https://deploy-preview-2114--kuma.netlify.app/docs/2.9.x/production/cp-deployment/kubernetes/
	403	https://argo-cd.readthedocs.io/en/stable/
https://deploy-preview-2114--kuma.netlify.app/docs/2.7.x/production/dp-config/cni/
	403	https://docs.cilium.io/en/v1.14/operations/upgrade/#id2
https://deploy-preview-2114--kuma.netlify.app/docs/2.7.x/production/cp-deployment/kubernetes/
	403	https://argo-cd.readthedocs.io/en/stable/
https://deploy-preview-2114--kuma.netlify.app/docs/2.8.x/production/dp-config/cni/
	403	https://docs.cilium.io/en/v1.14/operations/upgrade/#id2
https://deploy-preview-2114--kuma.netlify.app/docs/2.8.x/production/cp-deployment/kubernetes/
	403	https://argo-cd.readthedocs.io/en/stable/
Error: Process completed with exit code 1.

Did you sign your commit? Instructions

Have you read Contributing guidelines?

@Icarus9913 Icarus9913 requested a review from a team as a code owner December 10, 2024 09:38
@Icarus9913 Icarus9913 requested review from johncowen and slonka and removed request for a team December 10, 2024 09:38
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for kuma ready!

Name Link
🔨 Latest commit e66de01
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/67580c088795560008b4b2c4
😎 Deploy Preview https://deploy-preview-2116--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🟢 up 6 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Icarus9913 Icarus9913 merged commit e2bedc8 into kumahq:master Dec 10, 2024
16 checks passed
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some cases it makes sense to exclude external sites, in some cases it does not. Here we're linking to docs of argo an cilium which makes sense to monitor if they did not change the structure or something. I can reach https://docs.cilium.io/en/v1.14/operations/upgrade/#id2 so it seems that we've been blocked somehow. Let's try to fix the 403 instead of just removing everything.

Possible solutions:

  • run our link checker via a proxy
  • if we don't want to check live sites then maybe we should somehow "cache" the external websites on build and display them from the cache 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants