Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inspect-api): don't panic when outbound doesn't have 'kuma.io/service' tag #11613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lobkovilya
Copy link
Contributor

Since '/rules' is an old endpoint, this PR doesn't try to compute RuleAttachment for new outbounds with backendRef. It skips such outbounds to avoid panic.

Checklist prior to review

@lobkovilya lobkovilya requested a review from a team as a code owner October 1, 2024 13:02
@lobkovilya lobkovilya requested review from bartsmykla and lukidzi and removed request for a team October 1, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when calling /meshes/default/dataplanes/mycurlpod.kuma-demo/rules endpoint
2 participants