Make http client implementation configurable #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urbim
reviewed
Nov 30, 2020
| rest-client: | ||
| http-client-connector: jetty # or http-url, java native http client | ||
| enable-ssl-hostname-verification: true | ||
| disable-jetty-www-auth: true |
There was a problem hiding this comment.
Should we deprecate kumuluzee.rest-client.disable-jetty-www-auth and move it to kumuluzee.rest-client.jetty.disable-www-auth? Probably the enable-ssl-hostname-verification too.
By that I mean start using new config keys in READMEs but still support old keys as a fallback for some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses kumuluz/kumuluzee#185
The original issue can be temporarily solved by switching to http-url connector.
Jetty has default max read buffer size of 2MB which is not configurable at HttpClient level but only at Request level which is too late for us. Request is built inside jersey jetty connector so in order to support >2MB payloads a jersey patch is needed. I will try to adress the issue with upstream to move forward.
Additional problem is that http-url connector is not exposed by jersey (unlike jetty) to configure it in depth so that is the second issue I will try to adress upstream.
TODO: configure unit tests to run with http-url provider