Skip matching namespace if not found (#11)

* skip matching namespace if not found * update tests
kunicmarko20 · Apr 7, 2018 · 8e7b157 · 8e7b157
1 parent b3de700
commit 8e7b157
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/src/DependencyInjection/Compiler/AutoRegisterCompilerPass.php b/src/DependencyInjection/Compiler/AutoRegisterCompilerPass.php
@@ -30,7 +30,9 @@ public function process(ContainerBuilder $container): void
         $this->annotationReader = $container->get('annotation_reader');
 
         foreach ($this->findFiles($container->getParameter('sonata_annotation.directory')) as $file) {
-            $className = $this->getFullyQualifiedClassName($file);
+            if (!($className = $this->getFullyQualifiedClassName($file))) {
+                continue;
+            }
 
             if (!($annotation = $this->getClassAnnotation($reflection = new \ReflectionClass($className)))) {
                 continue;
@@ -58,15 +60,25 @@ private function findFiles(string $directory): \IteratorAggregate
             ->name('*.php');
     }
 
-    private function getFullyQualifiedClassName(SplFileInfo $file): string
+    private function getFullyQualifiedClassName(SplFileInfo $file): ?string
     {
-        return $this->getNamespace($file->getPathname()) . '\\' . $this->getClassName($file->getFilename());
+        if (!($namespace = $this->getNamespace($file->getPathname()))) {
+            return null;
+        }
+
+        return $namespace . '\\' . $this->getClassName($file->getFilename());
     }
 
-    private function getNamespace(string $filePath): string
+    private function getNamespace(string $filePath): ?string
     {
         $namespaceLine = preg_grep('/^namespace /', file($filePath));
+
+        if (!$namespaceLine) {
+            return null;
+        }
+
         preg_match('/namespace (.*);$/', reset($namespaceLine), $match);
+
         return array_pop($match);
     }
 

diff --git a/tests/Fixtures/MissingNamespaceClass.php b/tests/Fixtures/MissingNamespaceClass.php
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * @author Marko Kunic <[email protected]>
+ */
+final class MissingNamespaceClass
+{
+}