Add withQueryParameters to the RequestBuilder #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Request, so we add a way to add them via the bundle's RequestBuilder
tdashton
force-pushed
the
add-query-parameters-to-request-builder
branch
from
faf3a11 to
950523c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The objective of this PR is to provide a method to add query string parameters to the RequestBuilder.
Details
The query string parameters are read out of the URI in the Symfony Request, so we add a way to add them via the bundle's RequestBuilder.
In order for some types of requests, DELETE for example, it is necessary to provide the query string parameters via the uri in order for them to be parsed correctly in tests. See the details in Symfony's Request and parse_url.