fix: formatting via lsp is broken for another buffer #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When execute lsp format for another buffer, wrong and unexpected textEdit changes may will happen because internal lsp format request is issued with using the current buffer contents.
Reproduce steps
a.ts
.b.ts
format
extension enabled.a.ts
andb.ts
, and makeb.ts
the current buffer:e a.ts
,sp b.ts
a.ts
:call denops#notify('lspoints', 'executeCommand', ['format', 'execute', bufnr('a.ts')])
.a.ts
but, some textEdit changes are requested by deno lsp. (These changes cannot be actually applied fora.ts
, so you'll get an error message).Environment