Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve typing to avoid typescript build errors #2552

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: improve typing to avoid typescript build errors #2552

merged 1 commit into from
Oct 3, 2024
+5 −5

Conversation

Juiced66
Copy link
Contributor

@Juiced66 Juiced66 commented Oct 3, 2024

vault, kuzzleStateEnum, Validation where breaking KDM builds :

node_modules/kuzzle/lib/kuzzle/kuzzle.d.ts:136:22 - error TS2304: Cannot find name 'kuzzleStateEnum'.

136     set state(value: kuzzleStateEnum);

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Juiced66 Juiced66 self-assigned this Oct 3, 2024
@etrousset etrousset merged commit cde355a into 2-dev Oct 3, 2024
53 checks passed
@etrousset etrousset deleted the fix/improve-types-for-build-errors branch October 3, 2024 14:19
@kuzzle
Copy link
Contributor

kuzzle commented Oct 4, 2024

🎉 This PR is included in version 2.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kuzzle kuzzle added the released This issue/pull request has been released. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauNeko fmauNeko fmauNeko approved these changes

@Kuruyia Kuruyia Kuruyia approved these changes

@afondard afondard afondard approved these changes

Assignees

@Juiced66 Juiced66

Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Juiced66 @kuzzle @fmauNeko @Kuruyia @afondard @etrousset