Swift Package Manager Support #122
Conversation
|
Hello @kylef. I just wanted to let you know how much I appreciate your open-source project. It has proven to be incredibly useful and has become an essential tool for me. As I plan to continue using it in the future, I would like to kindly request that you consider adding support for the Swift Package Manager. This would greatly enhance its usability and make it even more valuable for users like myself. Thank you for your hard work and dedication to the project, and I look forward to seeing it continue to evolve. |
| @implementation MockingjayURLConfiguration | ||
|
|
||
| + (void)load { | ||
| [NSURLSessionConfiguration mockingjaySwizzleDefaultSessionConfiguration]; |
There was a problem hiding this comment.
This *.m file should be moved into YourProjectTests target, otherwise swizzling happens too lately. I understand the reason why you have removed this file, because SPM cannot compile source files in mixed languages. But it dramatically breaks swizzling
| @@ -40,7 +40,9 @@ public class MockingjayProtocol: URLProtocol { | |||
| stubs.append(stub) | |||
|
|
|||
| if !registered { | |||
| URLProtocol.registerClass(MockingjayProtocol.self) | |||
| MockingjayURLSessionConfiguration.swizzleDefaultSessionConfiguration() | |||
There was a problem hiding this comment.
Here is the problem, that swizzling happens too lately. Previously it was called right after the app instance has been loaded into memory in [NSObject load]; method, and then app used swizzled version of URLSessionConfiguration.default in tests target. Have to move MockingjayURLSessionConfiguration.m file into MyProjectTests target and add @import Mockingjay;
Hi.
This pull-request merges the current bug fixes and support for Swift Package Manager into a working code base.
You may consider merging the changes in a different order, but for now this works as reference for others looking for a working package with SPM support.
Hope this helps :) 👍