refactor: don't run isatty if we don't need to

isatty on stdout fails during tests, this change makes less tests
fail

goji/client.py

@@ -1,25 +1,14 @@
 import datetime
 import mimetypes
-import os
-import pickle
-from typing import Any, Generator, List, Optional
+from typing import Any, Dict, Generator, List, Optional
 
 import click
 import requests
 from requests.auth import AuthBase, HTTPBasicAuth
 from requests.compat import urljoin
 
-from goji.models import (
-    Attachment,
-    Comment,
-    Comments,
-    Issue,
-    IssueLinkType,
-    SearchResults,
-    Sprint,
-    Transition,
-    UserDetails,
-)
+from goji.models import (Attachment, Comment, Comments, Issue, IssueLinkType,
+                         SearchResults, Sprint, Transition, UserDetails)
 
 
 class JIRAException(click.ClickException):
@@ -170,7 +159,7 @@ def search(
         max_results: Optional[int] = None,
         start_at: Optional[int] = None,
     ) -> SearchResults:
-        body = {'jql': query}
+        body: Dict[str, Any] = {'jql': query}
 
         if start_at:
             body['startAt'] = start_at

goji/commands.py

@@ -1,4 +1,5 @@
 import importlib
+import io
 import pkgutil
 import sys
 from os import isatty
@@ -354,7 +355,7 @@ def search(client: JIRAClient, all: bool, count: bool, format: str, limit: Optio
         return
 
     formatter = Formatter()
-    fields = [v[1] for v in formatter.parse(format)]
+    fields = [v[1] for v in formatter.parse(format) if v[1]]
 
     if all:
         issues = client.search_all(query, fields=fields)
@@ -372,7 +373,7 @@ def search(client: JIRAClient, all: bool, count: bool, format: str, limit: Optio
             resolution=issue.resolution,
         )
 
-        if isatty(sys.stdout.fileno()):
+        if 'key' in fields and not isinstance(sys.stdout, io.TextIOWrapper) and isatty(sys.stdout.fileno()):
             url = urljoin(client.base_url, 'browse/%s' % issue.key)
             format_kwargs['key'] = f'\033]8;;{url}\a{issue.key}\033]8;;\a'
 

goji/models.py

@@ -68,10 +68,10 @@ def __init__(self, key: str):
         self.key = key
         self.summary = None
         self.description = None
-        self.creator: Optional[User] = None
+        self.creator: Optional[UserDetails] = None
         self.created: Optional[datetime] = None
         self.resolutiondate: Optional[datetime] = None
-        self.assignee: Optional[User] = None
+        self.assignee: Optional[UserDetails] = None
         self.status: Optional['StatusDetails'] = None
         self.resolution: Optional[Resolution] = None
         self.links: List['IssueLink'] = []

tests/models/test_issue.py

@@ -1,6 +1,7 @@
 import unittest
 
-from goji.models import Issue, IssueLink, IssueLinkType, StatusCategory, StatusDetails
+from goji.models import (Issue, IssueLink, IssueLinkType, StatusCategory,
+                         StatusDetails)
 from tests.server import OPEN_STATUS