chore: Refactor pkg/testutils package #4856
Annotations
10 errors and 1 warning
golangci-lint:
tests/e2e/commontestutils/watcher.go#L217
do not define dynamic errors, use wrapped static errors instead: "errors.New(\"getting lastModifiedAt time failed\")" (err113)
|
golangci-lint:
tests/integration/commontestutils/skrcontextimpl/dual_cluster.go#L48
error returned from external package is unwrapped: sig: func (*sigs.k8s.io/controller-runtime/pkg/envtest.Environment).Start() (*k8s.io/client-go/rest.Config, error) (wrapcheck)
|
golangci-lint:
tests/integration/commontestutils/skrcontextimpl/dual_cluster.go#L60
error returned from external package is unwrapped: sig: func (*sigs.k8s.io/controller-runtime/pkg/envtest.Environment).AddUser(user sigs.k8s.io/controller-runtime/pkg/internal/testing/controlplane.User, baseConfig *k8s.io/client-go/rest.Config) (*sigs.k8s.io/controller-runtime/pkg/internal/testing/controlplane.AuthenticatedUser, error) (wrapcheck)
|
golangci-lint:
tests/integration/commontestutils/skrcontextimpl/dual_cluster.go#L67
error returned from external package is unwrapped: sig: func sigs.k8s.io/controller-runtime/pkg/client.New(config *k8s.io/client-go/rest.Config, options sigs.k8s.io/controller-runtime/pkg/client.Options) (c sigs.k8s.io/controller-runtime/pkg/client.Client, err error) (wrapcheck)
|
golangci-lint:
tests/integration/controller/eventfilters/suite_test.go#L51
import "github.com/kyma-project/lifecycle-manager/tests/integration/commontestutils/skrcontextimpl" has alias "testskrcontext" which is not part of config (importas)
|
golangci-lint:
tests/integration/controller/kcp/suite_test.go#L52
import "github.com/kyma-project/lifecycle-manager/tests/integration/commontestutils/skrcontextimpl" has alias "testskrcontext" which is not part of config (importas)
|
golangci-lint:
tests/integration/controller/kyma/suite_test.go#L50
import "github.com/kyma-project/lifecycle-manager/tests/integration/commontestutils/skrcontextimpl" has alias "testskrcontext" which is not part of config (importas)
|
golangci-lint:
tests/integration/controller/purge/suite_test.go#L44
import "github.com/kyma-project/lifecycle-manager/tests/integration/commontestutils/skrcontextimpl" has alias "testskrcontext" which is not part of config (importas)
|
golangci-lint:
tests/integration/controller/withwatcher/suite_test.go#L58
import "github.com/kyma-project/lifecycle-manager/tests/integration/commontestutils/skrcontextimpl" has alias "testskrcontext" which is not part of config (importas)
|
golangci-lint
issues found
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Loading