Skip to content

Commit

Permalink
code review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
nesmabadr committed Jan 22, 2025
1 parent f00a8eb commit 78bdadb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions pkg/testutils/modulereleasemeta.go
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ func ModuleReleaseMetaBetaValueIsCorrect(ctx context.Context, client client.Clie
return err
}

if meta.Spec.Beta != expectedValue {
if meta.IsBeta() != expectedValue {
return ErrBetaValueNotCorrect
}

Expand All @@ -177,7 +177,7 @@ func ModuleReleaseMetaInternalValueIsCorrect(ctx context.Context, client client.
return err
}

if meta.Spec.Beta != expectedValue {
if meta.IsInternal() != expectedValue {
return ErrInternalValueNotCorrect
}

Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/modulereleasemeta_sync_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ var _ = Describe("ModuleReleaseMeta Sync", Ordered, func() {
Should(Succeed())
})

It("Then Beta value is reverted back to its value on the KCP Cluster", func() {
It("Then Beta value is reverted back to its value from the KCP Cluster", func() {
Eventually(ModuleReleaseMetaBetaValueIsCorrect).
WithContext(ctx).
WithArguments(skrClient, RemoteNamespace, module.Name, false).
Expand All @@ -93,7 +93,7 @@ var _ = Describe("ModuleReleaseMeta Sync", Ordered, func() {
Should(Succeed())
})

It("Then Internal value is reverted back to its value on the KCP Cluster", func() {
It("Then Internal value is reverted back to its value from the KCP Cluster", func() {
Eventually(ModuleReleaseMetaInternalValueIsCorrect).
WithContext(ctx).
WithArguments(skrClient, RemoteNamespace, module.Name, false).
Expand Down

0 comments on commit 78bdadb

Please sign in to comment.