adjust tests with hardcoded names

kyma-project · Jan 17, 2025 · a2e3ae1 · a2e3ae1
1 parent 191a814
commit a2e3ae1
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 92 deletions.
diff --git a/internal/pkg/metrics/module.go b/internal/pkg/metrics/module.go
diff --git a/tests/e2e/commontestutils/metrics.go b/tests/e2e/commontestutils/metrics.go
@@ -153,36 +153,6 @@ func GetMandatoryModuleStateMetric(ctx context.Context, kymaName, moduleName, st
 	return parseCount(re, bodyString)
 }
 
-func GetModuleCRWarningConditionMetric(ctx context.Context, kymaName, moduleName string) (int, error) {
-	bodyString, err := getMetricsBody(ctx)
-	if err != nil {
-		return 0, err
-	}
-
-	re := getModuleCRWarningConditionMetric(kymaName, moduleName)
-	return parseCount(re, bodyString)
-}
-
-func getModuleCRWarningConditionMetric(kymaName, moduleName string) *regexp.Regexp {
-	return regexp.MustCompile(fmt.Sprintf(`%s{condition="ModuleCRWarning",kyma_name="%s",module_name="%s"} (\d+)`,
-		metrics.MetricModuleCondition, kymaName, moduleName))
-}
-
-func ModuleCRWarningConditionMetricNotFound(ctx context.Context, kymaName, moduleName string) error {
-	bodyString, err := getMetricsBody(ctx)
-	if err != nil {
-		return err
-	}
-
-	re := getModuleCRWarningConditionMetric(kymaName, moduleName)
-	match := re.FindStringSubmatch(bodyString)
-	if len(match) < 1 {
-		return ErrMetricNotFound
-	}
-
-	return nil
-}
-
 func getMetricsBody(ctx context.Context) (string, error) {
 	clnt := &http.Client{}
 	request, err := http.NewRequestWithContext(ctx, http.MethodGet, "http://localhost:9081/metrics", nil)

diff --git a/tests/e2e/module_status_decoupling_test.go b/tests/e2e/module_status_decoupling_test.go
@@ -93,11 +93,6 @@ func RunModuleStatusDecouplingTest(resourceKind ResourceKind) {
 				WithContext(ctx).
 				WithArguments(skrClient, moduleCR, shared.StateWarning).
 				Should(BeTrue())
-			By("And count of metrics lifecycle_mgr_module_condition is 1")
-			Eventually(GetModuleCRWarningConditionMetric).
-				WithContext(ctx).
-				WithArguments(kyma.GetName(), TestModuleName).
-				Should(Equal(1))
 		})
 
 		It("When blocking finalizers from Module CR get removed", func() {
@@ -139,12 +134,6 @@ func RunModuleStatusDecouplingTest(resourceKind ResourceKind) {
 				WithContext(ctx).
 				WithArguments(kyma.GetName(), kyma.GetNamespace(), kcpClient, shared.StateReady).
 				Should(Succeed())
-
-			By("And count of metrics lifecycle_mgr_module_condition is removed")
-			Eventually(ModuleCRWarningConditionMetricNotFound).
-				WithContext(ctx).
-				WithArguments(kyma.GetName(), TestModuleName).
-				Should(Equal(ErrMetricNotFound))
 		})
 	})