Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests for templatelookup #2204

Open
1 task
c-pius opened this issue Jan 23, 2025 · 0 comments
Open
1 task

Adapt tests for templatelookup #2204

c-pius opened this issue Jan 23, 2025 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@c-pius
Copy link
Contributor

c-pius commented Jan 23, 2025

Description

Once we have good coverage for moduletemplateinfolookup (see #2202), we need to adapt the testing of templatelookup (regular_test.go). Right now, we implicitly test the functionality of the template lookup dependency moduletemplateinfolookup. We need to refactor the test to remove the implicit testing of this dependency and focus on the templatelookup as actual unit under test.

This comment is super valid, but it is hard to achieve now because the tests expect things that are internal to the dependency. #2200 (comment)

Also this comment needs to be considered: #2200 (comment)

Reasons

Follow-up from #2200

We moved lot's of functionality from templatelookup to moduletemplateinfolookup. We also need to adapt the unit testing accordingly to focus for the unit under test, not implicitly test dependencies.

Acceptance Criteria

  • regular_test.go tests functionality of templatelookup, not moduletemplateinfolookup

Feature Testing

No response

Testing approach

No response

Attachments

No response

@c-pius c-pius added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant