-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor template lookup to use strategy pattern #2200
Merged
lindnerby
merged 16 commits into
kyma-project:main
from
c-pius:feat/refactor-template-lookup
Jan 23, 2025
Merged
feat: Refactor template lookup to use strategy pattern #2200
lindnerby
merged 16 commits into
kyma-project:main
from
c-pius:feat/refactor-template-lookup
Jan 23, 2025
+950
−451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-pius
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Jan 21, 2025
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Jan 21, 2025
7 tasks
c-pius
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Jan 22, 2025
lindnerby
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Just left some mostly testing related suggestions 🙌
pkg/templatelookup/moduletemplateinfolookup/by_module_release_meta_test.go
Outdated
Show resolved
Hide resolved
This was referenced Jan 23, 2025
lindnerby
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
💡 Note to reviewer
templatelookup
regular.go
to the strategies inmoduletempalteinfolookup
Related issue(s)