Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Labelling SKR resources #2158

Merged
merged 5 commits into from
Jan 7, 2025
Merged

test: Labelling SKR resources #2158

merged 5 commits into from
Jan 7, 2025

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Jan 3, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • introduces labelling test that verifies if:
    • watched-by is present on KymaCR
    • managed-by is present on KLM-managed SKR resources
    • istio and warden labels are present on kyma-system namespace
    • managed-by is present on KLM-managed module manifest resources
    • managed-by is present on module default CR
  • removes redundant label checks in other e2e tests where not relevant for the test itself

Related issue(s)

@c-pius c-pius requested a review from a team as a code owner January 3, 2025 10:15
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2025
@c-pius c-pius added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Jan 3, 2025
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2025
@c-pius c-pius removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2025
medmes
medmes approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@medmes medmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 7, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 7, 2025
@kyma-bot
Copy link
Contributor

kyma-bot commented Jan 7, 2025

New changes are detected. LGTM label has been removed.

@medmes medmes assigned c-pius and unassigned medmes Jan 7, 2025
@c-pius c-pius enabled auto-merge (squash) January 7, 2025 11:22
@c-pius c-pius merged commit f606b59 into kyma-project:main Jan 7, 2025
68 checks passed
@c-pius c-pius deleted the test/labelling branch January 7, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medmes medmes medmes approved these changes

Assignees

@c-pius c-pius

Labels
cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement an E2E Test verifying the expected labels on KymaCR
3 participants
@c-pius @kyma-bot @medmes