Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cleanup certificates when kyma with skip-reconciliation gets deleted after the label removal #2162

Merged
merged 9 commits into from
Jan 8, 2025
Merged

fix: Cleanup certificates when kyma with skip-reconciliation gets deleted after the label removal #2162

merged 9 commits into from
Jan 8, 2025

Conversation

nesmabadr
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Cleanup certificates when kyma with skip-reconciliation gets deleted after the label removal
  • Add E2E test

Related issue(s)
Resolves #1965

@nesmabadr nesmabadr added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2025
@nesmabadr nesmabadr requested a review from a team as a code owner January 7, 2025 11:10
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 7, 2025
@nesmabadr nesmabadr added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2025
@nesmabadr nesmabadr force-pushed the certificates_deletion branch from 14272c2 to 5875cc6 Compare January 7, 2025 11:19
@nesmabadr nesmabadr force-pushed the certificates_deletion branch from 5bd3663 to acc7ee4 Compare January 7, 2025 11:51
@nesmabadr nesmabadr force-pushed the certificates_deletion branch from acc7ee4 to 2774325 Compare January 7, 2025 12:09
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2025
@nesmabadr nesmabadr force-pushed the certificates_deletion branch from 202355a to efffa6d Compare January 7, 2025 12:54
@nesmabadr nesmabadr force-pushed the certificates_deletion branch from fba6c34 to 1d622e3 Compare January 7, 2025 13:46
@nesmabadr nesmabadr requested a review from c-pius January 8, 2025 08:51
@nesmabadr nesmabadr removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 8, 2025
@nesmabadr nesmabadr merged commit a4c34ce into kyma-project:main Jan 8, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-pius c-pius c-pius approved these changes

Assignees

@c-pius c-pius

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent orphaned certificates when deleting orphaned Kyma with skip-reconciliation
3 participants
@nesmabadr @c-pius @kyma-bot