Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Read Maintenance Window Policies #2171

Merged
merged 24 commits into from
Jan 17, 2025
Merged

feat: Read Maintenance Window Policies #2171

merged 24 commits into from
Jan 17, 2025

Conversation

nesmabadr
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Add maintenance-config config map to local setup and mount the volume to the manager container in the klm deployment

Related issue(s)
Resolves #2163

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 13, 2025
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 13, 2025
@nesmabadr nesmabadr force-pushed the read_maintwindows branch 2 times, most recently from ea0e1cb to f06855d Compare January 13, 2025 14:25
@nesmabadr nesmabadr marked this pull request as ready for review January 15, 2025 14:51
@nesmabadr nesmabadr requested a review from a team as a code owner January 15, 2025 14:51
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2025
@lindnerby lindnerby self-assigned this Jan 16, 2025
@lindnerby lindnerby enabled auto-merge (squash) January 17, 2025 10:29
@lindnerby
Copy link
Member

As discussed: For now we will keep the usage of resolver logic like it is here with reduced capabilities of testing and accept the low coverage. Within the follow-ups of #2189 & #2190 we will move the module to a separate public repo and replace the usage here to be able to reach max test coverage.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 17, 2025
@lindnerby lindnerby merged commit 2356fa5 into kyma-project:main Jan 17, 2025
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindnerby lindnerby lindnerby approved these changes

Assignees

@lindnerby lindnerby

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maintenance Windows] Read maintenance window policies
3 participants
@nesmabadr @lindnerby @kyma-bot