-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Removed skr permission and cache config for remote kyma & ModuleTemp… #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Jan 21, 2025
medmes
changed the title
Removed skr permission and cache config for remote kyma & ModuleTemp…
Feat: Removed skr permission and cache config for remote kyma & ModuleTemp…
Jan 21, 2025
10 tasks
medmes
changed the title
Feat: Removed skr permission and cache config for remote kyma & ModuleTemp…
feat: Removed skr permission and cache config for remote kyma & ModuleTemp…
Jan 21, 2025
lindnerby
requested changes
Jan 23, 2025
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Jan 23, 2025
medmes
force-pushed
the
feat/cache_check
branch
from
January 23, 2025 12:27
90ad66f
to
bd5efdf
Compare
lindnerby
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After investigation , When using the default client configuration(which is the normal behaviour we use) there's no possibility to verify if the resource is retrieved by infomrer queue. or from a direct API read.
The only way, is to roll out the resources cache configuration and test it by observing metrics on Stage.
Changes proposed in this pull request:
Related issue(s)
#2083