Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removed skr permission and cache config for remote kyma & ModuleTemp… #2198

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

medmes
Copy link
Member

@medmes medmes commented Jan 21, 2025

Description
After investigation , When using the default client configuration(which is the normal behaviour we use) there's no possibility to verify if the resource is retrieved by infomrer queue. or from a direct API read.
The only way, is to roll out the resources cache configuration and test it by observing metrics on Stage.

Changes proposed in this pull request:

  • Removed cache config for Kyma and ModuleTemplate resource.
  • Remove unnessery role, role_binding manifests for skr permission.

Related issue(s)
#2083

@medmes medmes requested a review from a team as a code owner January 21, 2025 11:12
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 21, 2025
@medmes medmes self-assigned this Jan 21, 2025
@medmes medmes changed the title Removed skr permission and cache config for remote kyma & ModuleTemp… Feat: Removed skr permission and cache config for remote kyma & ModuleTemp… Jan 21, 2025
@medmes medmes linked an issue Jan 21, 2025 that may be closed by this pull request
10 tasks
@medmes medmes changed the title Feat: Removed skr permission and cache config for remote kyma & ModuleTemp… feat: Removed skr permission and cache config for remote kyma & ModuleTemp… Jan 21, 2025
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2025
@lindnerby lindnerby enabled auto-merge (squash) January 23, 2025 11:53
@lindnerby lindnerby merged commit 3d85fd0 into kyma-project:main Jan 23, 2025
68 of 69 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 23, 2025
@medmes medmes deleted the feat/cache_check branch January 23, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate need for kyma-system cache options
3 participants