Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Nil pointer when unmanaging module with Ignore CustomResourcePolicy #2233

Merged
merged 5 commits into from
Feb 5, 2025
Merged

fix: Nil pointer when unmanaging module with Ignore CustomResourcePolicy #2233

merged 5 commits into from
Feb 5, 2025

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Feb 5, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • fixes the nil pointer exception
  • refactors the label removal service
    • it should be e2e responsible for label removal from all objects
    • therefore, the check if needed for defaultCR and respective lookup moved from reconciler into the service
    • this way the removal can now be completely unit tested
  • extends the unmanaging e2e test to include the case wehere CustomResourcePolicy is Ignore

Related issue(s)

@c-pius c-pius requested a review from a team as a code owner February 5, 2025 10:31
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 5, 2025
@c-pius c-pius added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cla: yes Indicates the PR's author has signed the CLA. labels Feb 5, 2025
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 5, 2025
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 5, 2025
@c-pius c-pius removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2025
@c-pius c-pius changed the title fix: Nil ptr when unmanaging module with Ignore policy fix: Nil pointer when unmanaging module with Ignore CustomResourcePlicy Feb 5, 2025
@c-pius c-pius changed the title fix: Nil pointer when unmanaging module with Ignore CustomResourcePlicy fix: Nil pointer when unmanaging module with Ignore CustomResourcePolicy Feb 5, 2025
@lindnerby lindnerby self-assigned this Feb 5, 2025
lindnerby
lindnerby approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@lindnerby lindnerby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 5, 2025
@lindnerby lindnerby merged commit d9ec6ba into kyma-project:main Feb 5, 2025
257 of 263 checks passed
@c-pius c-pius deleted the fix/nil-ptr-on-removing-managed-by-label branch February 5, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindnerby lindnerby lindnerby approved these changes

Assignees

@lindnerby lindnerby

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nil Pointer Reference in Manifest Reconciler if
3 participants
@c-pius @lindnerby @kyma-bot