Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use shared GitHub Actions #247

Merged
merged 19 commits into from
Apr 17, 2024

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Apr 5, 2024

Description

Changes proposed in this pull request:

Related issue(s)

Comments

To ease the review allowing to compare the new workflow runs against the old ones, the old test-e2e.yaml workflow is still there unchanged and the new workflow is in test-e2e-junk.yaml. Once the changes are good to go, the old file will be updated with the new workflow and the separate junk file will be deleted.

When reviewing, it is probably best to start from test-e2e-junk.yaml and from there look into the used helper actions.

@c-pius c-pius requested a review from a team as a code owner April 5, 2024 12:13
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 5, 2024
@c-pius c-pius force-pushed the chore/shared-github-actions branch 2 times, most recently from 53096c6 to 0233f64 Compare April 5, 2024 12:15
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2024
@c-pius c-pius force-pushed the chore/shared-github-actions branch from 58bb704 to 4272a59 Compare April 16, 2024 11:18
@c-pius c-pius changed the title wip: Introduce shared GitHub Actions chore: Introduce shared GitHub Actions Apr 16, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2024
@c-pius c-pius force-pushed the chore/shared-github-actions branch from 23bd44e to bb080d2 Compare April 16, 2024 11:25
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2024
@c-pius c-pius changed the title chore: Introduce shared GitHub Actions chore: Use shared GitHub Actions Apr 16, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2024
.github/workflows/test-e2e-junk.yaml Outdated Show resolved Hide resolved
.github/workflows/test-e2e-junk.yaml Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 17, 2024
@kyma-bot kyma-bot merged commit 12ba4a9 into kyma-project:main Apr 17, 2024
11 checks passed
@c-pius c-pius deleted the chore/shared-github-actions branch April 17, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E config improvement
3 participants