Fix literal float and string comparisons

kynx · Feb 23, 2024 · 3a50880 · 3a50880
1 parent b5719ee
commit 3a50880
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/Psalm/TypeComparator.php b/src/Psalm/TypeComparator.php
@@ -125,6 +125,10 @@ private static function isContainedByInheritance(Atomic $type, Atomic $container
             return false;
         }
 
+        if ($type instanceof TFloat && $container instanceof TLiteralFloat) {
+            return false;
+        }
+
         if ($type instanceof TInt && $container instanceof TInt) {
             return self::isContainedByInt($type, $container);
         }
@@ -172,6 +176,9 @@ private static function isContainedByString(Atomic $type, Atomic $container): bo
         if (! ($type instanceof TString && $container instanceof TString)) {
             return false;
         }
+        if ($type instanceof TLiteralString && $container instanceof TLiteralString) {
+            return $type->value === $container->value;
+        }
 
         if ($type::class === $container::class) {
             return true;