revisiting orderBy.
#1326
Merged
revisiting orderBy.
#1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igalklebanov
changed the title
orderBy - deperecate (ref direction), (expr, expr), introduce OrderByItemBuilder.
igalklebanov
changed the title
orderBy - deperecate (ref direction), (expr, expr), introduce OrderByItemBuilder.orderBy - deperecate (ref direction), (expr, expr), (array), introduce OrderByItemBuilder.
igalklebanov
changed the title
orderBy - deperecate (ref direction), (expr, expr), (array), introduce OrderByItemBuilder.orderBy - deperecate (ref direction), (expr, expr), (array), introduce OrderByItemBuilder, OrderByInterface.
igalklebanov
added
enhancement
This was
linked to
issues
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
fixes #1300
closes #1209
closes #714
This PR revisits and shows some love to
orderBy.orderByis everywhere now (select,delete,over, function arguments, etc.), so it only makes sense to extract it to its ownOrderByInterfaceand its node methods toQueryNodeto ease maintenance and dry up things.orderByhas been added toUpdateQueryBuilder- supported only in MySQL.orderBy('column asc')andorderBy([...])- which are up to ~3x worse in compile-time performance than alternatives, and an inelegant limiting solution now thatorderByis not just aboutasc|desc.orderBy(..., (ob) => ob.collate('nocase').asc().nullFirst())is added. Supportingnulls {first|last}(PostgreSQL/SQLite) - one of the most requested features according to GitHub reactions,collate <collation>, andasc|desc.