Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusted buffers to increase performance #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adjusted buffers to increase performance #120

wants to merge 1 commit into from

Conversation

empirephoenix
Copy link

Hi,
i basically just tested a bit around with somewhat current hardware (i7 6000 generation) what size of buffer seems to allow a good tradeoff between performance and memory useage.
Increasing the buffers as done here, increased the performance for larger files (>prior buffer) multiple times, eg a 500mb mp4 downloads with 100MByte/s instead of 1Mbyte/s.

@kzahel
Copy link
Owner

kzahel commented Dec 14, 2017

That's a ~67MB read buffer and writing 4MB at a time.
Thank you for doing the performance testing.

I will check it out and test locally and see how it goes when I get the chance soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants