-
Notifications
You must be signed in to change notification settings - Fork 35
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add possibility to change the display mode (atom <-> structure) (#351)
Where to play around with modes: ``` npm i npm run start ``` Open the `Chemical Shieldings` example ``` tox -e docs python3 -m http.server ``` Open `examples/2-structure_map.html` TODO: - [x] change in EnvironmentInfo - [x] change in map - [x] change in structure - [x] move mode out of indexer - [x] add loader - [x] change UI of toggle - [x] testing (played with the examples from chemiscope.org & in doc/examples) After review: - [x] UI: add titles to buttons; substruct height of buttons in the map; reset color range - [x] Code: document, delete usage of settings while changing the mode; fully recreate mapOptions - [x] ~~Display errors as errors instread of warning~~ --> throw error, change logging in separate PR - [x] Add `mode` to the settings Note for exporting/importing of the dataset: - If mode is changed and z-axes is not selected, we export NaN to JSON as `z.min` and `z.max`; hence it breaks once someone wants to import this dataset to the chemiscope. To do the import, it is necessary to delete the z-axes from the json settings (or set 0). - This bug to be fixed in the separate PR --------- Co-authored-by: Guillaume Fraux <[email protected]> Co-authored-by: Michele Ceriotti <[email protected]> Co-authored-by: Michele Ceriotti <[email protected]>
- Loading branch information
1 parent
5a43392
commit 49b1182
Showing
16 changed files
with
1,214 additions
and
480 deletions.
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.