Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GZIP magic bytes to detect whether a file is compressed #360

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Use GZIP magic bytes to detect whether a file is compressed #360

merged 1 commit into from
Aug 30, 2024

Conversation

Luthaf
Copy link
Contributor

@Luthaf Luthaf commented Aug 30, 2024

This should fix #359.

@Luthaf Luthaf mentioned this pull request Aug 30, 2024
Closed
ceriottm
ceriottm approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@ceriottm ceriottm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I tested it works - at least with tox and nox builds. Don't see why it wouldn't work on readthedocs.

@ceriottm ceriottm merged commit 52a2cc1 into lab-cosmo:main Aug 30, 2024
6 checks passed
@Luthaf Luthaf deleted the gzip-detect branch August 30, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceriottm ceriottm ceriottm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obtaining "incorrect header check" in Sphinx
2 participants
@Luthaf @ceriottm