Adding support for WSL #5
Conversation
|
You don't need to change the SDK makefiles - we have our own set of makefiles that manage flashing in the |
|
This definitely doesn't work, right? @nealjack's right that the only makefiles we use from apps are in the |
|
Yeah. I rolled back the SDK changes, and modified the |
make/README.md
Outdated
| that doesn't work. | ||
| We develop on Linux. This also works on Windows in either of the following ways: | ||
| 1. Build on WSL (Windows Subsystem for Linux), and `flash` with WSL. | ||
| 2. Build with SES (Segger Embedded Studio) and `flash` with WSL. Note: For this you will have to manually move the `.hex` file generated from SES to `build/` directory. For e.g. `mv blinky/pca10040/s132/ses/Output/Release/Exe/blinky_pca10040_s132.hex blinky/_build/blink_sdk16_blank.hex`. |
There was a problem hiding this comment.
What is blinky? It would be better to give instructions for an application in the apps/basic/ directory.
There was a problem hiding this comment.
For the nrf52x-base/apps/basic/blink it works as is. You just have to make flash.
The second option is if you are using SES from the SDK.
There was a problem hiding this comment.
regardless "blinky" isn't an application we have in the repo
There was a problem hiding this comment.
I see. Is there really any reason to list the SES option at all? It doesn't really let you build nrf52x-base applications, just apps in the SDK, which aren't our purview.
There was a problem hiding this comment.
I think there is value to provide minimal support to SES.
@nealjack Good point. Thanks.
There was a problem hiding this comment.
But there isn't really support for SES. To support SES would mean taking an application from the apps/ folder, compiling it with SES, and then flashing it. But that is not going to work.
| else | ||
| $(Q)printf "loadfile $(HEX) \nr\ng\nexit\n" >> $(BUILDDIR)flash.jlink | ||
| $(Q)$(JLINK) $(JLINK_FLAGS) $(BUILDDIR)flash.jlink | ||
| else ifeq ($(USE_BOOTLOADER),0) |
There was a problem hiding this comment.
We also want to leave this line as just an else with no check. USE_BOOTLOADER may not be defined at all, in which case it won't be equal to zero.
There was a problem hiding this comment.
Honestly, the better design might just be to leave the logic that creates the flash.jlink file alone. It shouldn't hurt anything to create that file on windows even if you don't use it. Then you can create one if check that decides if you're windows and uses nrfjprog or else falls back on the existing JLINK infrastructure
There was a problem hiding this comment.
fwiw, ifeq ($(USE_BOOTLOADER),) will evaluate to true if the variable is undefined
|
@ShishirPatil did you want to keep trying to get this pulled into this repo? If so, what is the current status? |
Adding
make flashsupport fora) WSL on Windows, and
b) SES on Windows