Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail 4 #195

Merged
merged 7 commits into from
Nov 23, 2022
Merged

Wagtail 4 #195

merged 7 commits into from
Nov 23, 2022

Conversation

katdom13
Copy link
Contributor

Release notes:
https://docs.wagtail.org/en/stable/releases/4.0.html

  • Updated tox.ini and workflows
  • Updated documentation
  • Fixed imports

Tests pass

collected 40 items                                                                                                                                                                      

tests/test_hooks.py ....                                                                                                                                                          [ 10%]
tests/test_middleware.py ......s.....                                                                                                                                             [ 40%]
tests/test_mixins.py ....                                                                                                                                                         [ 50%]
tests/test_views.py ..............                                                                                                                                                [ 85%]
tests/test_apps.py .....                                                                                                                                                          [ 97%]
tests/test_mixins.py .                                                                                                                                                            [100%]

Copy link
Contributor

@nickmoreton nickmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments.

The github workflows could be simpler and I don't think the sandbox app needs any changes other that to update it for wagtail v4, without the conditionals for older versions.

@nickmoreton
Copy link
Contributor

Thanks @katdom13 LGTM 👍

@robmoorman
Copy link

Great works guys. @davisnando @mikedingjan if it's ok we would like to help you with maintaining this package in order to boost compatibility delays :). If not would be great to get this working for django/wagtail 4!

@th3hamm0r
Copy link
Contributor

Fyi: We also had a crash with the otp_form.html with wagtail >= 4 (reported here #187), for which I've created a PR #196.

@davisnando
Copy link
Member

@robmoorman You can always create pull requests so feel free to help

@robmoorman
Copy link

He @davisnando would help a lot to review this PR and #196 ;)

@davisnando davisnando merged commit b3f9cc7 into labd:master Nov 23, 2022
@davisnando
Copy link
Member

Tested and didn't found any issues

@zerolab zerolab mentioned this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants