Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for LabelManager Wireless PnP #81

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thinkl33t
Copy link

@thinkl33t thinkl33t commented Sep 29, 2024

Some initial work on LabelManager Wireless PnP

  • add auto cut to end of print statement (this is added to every print - in testing with a LabelManager PnP this doesn't effect anything on devices without a cutter)
  • add 24mm to valid label sizes

still to do:

  • printer doesn't output anything when cold-booted until it has been printed to once by another application - currently i'm using dymoconf/render-label.py and sending it to port 9100 on the printer to do this initialization
  • when things are printed out, they come out very squished - i suspect i need to fiddle with LABELER_PRINT_HEAD_HEIGHT_MM depending on the specific labeller but i could be wrong here - i can't find any codepaths that differ between devices at the moment

@maresb
Copy link
Contributor

maresb commented Sep 29, 2024

The current situation with the codebase is unfortunately a bit precarious. We have forked into a develop branch which is unfortunately broken, but that adds some stuff to sanely support other devices. There's still a bit of cleanup to do before we can bring it into main though, so I'd recommend keeping this PR slim to avoid duplicating work and increasing the likelihood that we can merge.

@maresb
Copy link
Contributor

maresb commented Sep 29, 2024

I appreciate a lot that you're showing your work early. For purely organizational purposes I'm going to convert this to a draft. Please feel free to mark it as "ready for review" and ping us whenever you'd like us to take another look at it.

@maresb maresb marked this pull request as draft September 29, 2024 15:47
@thinkl33t
Copy link
Author

After some more experimentation, sending the cut for every printer seems to crash out printers with no cutters, so i'm going to try and rework this against your develop branch :)

@maresb
Copy link
Contributor

maresb commented Oct 7, 2024

That's strange, which printers are you testing against? I'm fairly confident that with my PnP the cut command was a noop, but I don't have it at the moment.

Please be warned that there's no timeline for merging develop into main, just to calibrate your expectations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants