Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the model service creation desired routing count max value setting #2723

Closed
ironAiken2 opened this issue Sep 27, 2024 · 0 comments · Fixed by #2726
Closed

Change the model service creation desired routing count max value setting #2723

ironAiken2 opened this issue Sep 27, 2024 · 0 comments · Fixed by #2726
Assignees

Comments

@ironAiken2
Copy link
Contributor

ironAiken2 commented Sep 27, 2024

What Operating System(s) are you seeing this problem on?

macOS (Apple Silicon)

Backend.AI version

24.09.0dev1

Describe the bug

Currently, the maxValue of DesiredRoutingCount, which is set when creating a model service in the webui, is hardcoded to 10. ref teams

By Backend.ai Core policy, routing session is set to follow the max_session_count_per_model_session value, so the max value of DesiredRoutingCount in the webui must also be changed to follow that value.

To Reproduce

No response

Expected Behavior

No response

Anything else?

No response

yomybaby pushed a commit that referenced this issue Sep 30, 2024
…Launcher modal to follow `max_session_count_per_model_session` (#2726)

### This PR resolves [#2723 Issue](#2723)

[teams](https://teams.microsoft.com/l/message/19:[email protected]/1727418901786?tenantId=13c6a44d-9b52-4b9e-aa34-0513ee7131f2&groupId=74ae2c4d-ec4d-4fdf-b2c2-f5041d1e8631&parentMessageId=1727418901786&teamName=devops&channelName=Backend.AI%20Talks&createdTime=1727418901786)

This PR introduces a new query to fetch the user's resource policy and applies the `max_session_count_per_model_session` limit to the service launcher page. The changes include:

- Added two new queries: `ServiceLauncherPageContent_UserInfoQuery` and `ServiceLauncherPageContent_UserResourcePolicyQuery`
- Utilized `useLazyLoadQuery` to fetch user information and resource policy
- Applied the `max_session_count_per_model_session` from the user's resource policy to the session count input field

These changes allow for dynamic session count limits based on the user's resource policy, improving the flexibility and customization of the service launcher.

**Checklist:**

- [ ] Documentation update for new resource policy feature
- [ ] Minimum required manager version: 23.09.6
- [ ] Test cases to verify the application of custom max session count limits
@ironAiken2 ironAiken2 self-assigned this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant