fix: Fixed the maximum desired number of sessions value in the Model Launcher modal to follow max_session_count_per_model_session
#2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ironAiken2 and the rest of your teammates on |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.33% (-0% 🔻) |
340/6381 |
| 🔴 | Branches | 4.82% (-0.01% 🔻) |
214/4439 |
| 🔴 | Functions | 3% | 63/2101 |
| 🔴 | Lines | 5.23% (-0% 🔻) |
326/6234 |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from 25973e0
ironAiken2
force-pushed
the
fix/model-launcher-modal-max-session-value
branch
from
f66479e
to
cf140d3
Compare
yomybaby
requested changes
Sep 30, 2024
ironAiken2
force-pushed
the
fix/model-launcher-modal-max-session-value
branch
from
cf140d3
to
5ff923f
Compare
github-actions
bot
added
area:ux
|
When max value is 0, the error message was showing "value between 0 and 0", so �I fixed that as well. @yomybaby |
yomybaby
requested changes
Sep 30, 2024
ironAiken2
force-pushed
the
fix/model-launcher-modal-max-session-value
branch
2 times, most recently
from
1a7b543
to
e7800ef
Compare
yomybaby
approved these changes
Sep 30, 2024
Merge activity
|
…Launcher modal to follow `max_session_count_per_model_session` (#2726) ### This PR resolves [#2723 Issue](#2723) [teams](https://teams.microsoft.com/l/message/19:[email protected]/1727418901786?tenantId=13c6a44d-9b52-4b9e-aa34-0513ee7131f2&groupId=74ae2c4d-ec4d-4fdf-b2c2-f5041d1e8631&parentMessageId=1727418901786&teamName=devops&channelName=Backend.AI%20Talks&createdTime=1727418901786) This PR introduces a new query to fetch the user's resource policy and applies the `max_session_count_per_model_session` limit to the service launcher page. The changes include: - Added two new queries: `ServiceLauncherPageContent_UserInfoQuery` and `ServiceLauncherPageContent_UserResourcePolicyQuery` - Utilized `useLazyLoadQuery` to fetch user information and resource policy - Applied the `max_session_count_per_model_session` from the user's resource policy to the session count input field These changes allow for dynamic session count limits based on the user's resource policy, improving the flexibility and customization of the service launcher. **Checklist:** - [ ] Documentation update for new resource policy feature - [ ] Minimum required manager version: 23.09.6 - [ ] Test cases to verify the application of custom max session count limits
yomybaby
force-pushed
the
fix/model-launcher-modal-max-session-value
branch
from
f2e7b26
to
25973e0
Compare
graphite-app
bot
deleted the
fix/model-launcher-modal-max-session-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2723 Issue
teams
This PR introduces a new query to fetch the user's resource policy and applies the
max_session_count_per_model_sessionlimit to the service launcher page. The changes include:ServiceLauncherPageContent_UserInfoQueryandServiceLauncherPageContent_UserResourcePolicyQueryuseLazyLoadQueryto fetch user information and resource policymax_session_count_per_model_sessionfrom the user's resource policy to the session count input fieldThese changes allow for dynamic session count limits based on the user's resource policy, improving the flexibility and customization of the service launcher.
Checklist: