-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse fgpu slots to float #1759
Conversation
@@ -313,9 +313,9 @@ export default class BackendAIAgentList extends BackendAIPage { | |||
agents[objectKey].total_cuda_gpu_percent = (agents[objectKey].used_cuda_gpu_slots_ratio * 100).toFixed(2); | |||
} | |||
if ('cuda.shares' in available_slots) { | |||
agents[objectKey].cuda_fgpu_slots = parseInt(available_slots['cuda.shares']); | |||
agents[objectKey].cuda_fgpu_slots = parseFloat(available_slots['cuda.shares']).toFixed(2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing ? before .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be okay to be merged after applying updates according to @inureyes 's comment in [here](https://github.com/lablup/backend.ai-webui/pull/1759/files#r1251734318.
resolves https://github.com/lablup/giftbox/issues/429