-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Disable primary keypair deletion #2083
Conversation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 3.6% | 97/2696 |
🔴 | Branches | 3.77% | 61/1619 |
🔴 | Functions | 1.66% | 15/902 |
🔴 | Lines | 3.66% | 97/2652 |
Test suite run success
17 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from f0d88e1
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested just one additional condition. Other things are LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
24.03.0
or newer versionIn this PR, most of implementation is mainly focused on "main_access_key", considering the relationship between user and keypair (user can have multiple keypairs.)
Main Access Key
tag in Access key column where access key is the main access keyMain Access Key
Column in users tabMain Access Key
in User detail dialogChecklist: (if applicable)
Screenshot(s)