feat: improve wsproxy address validation #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
ironAiken2
reviewed
Aug 6, 2024
github-actions
bot
added
effort:easy
ironAiken2
force-pushed
the
feature/wsproxy-address-validation
branch
from
72c2a62
to
40046ac
Compare
Merge activity
|
resolves #2597 This pull request addresses a cosmetic issue by fixing a typo in the variable naming convention for resourceGroupWSProxyAddressInput. It also includes enhancements to the styling of the input fields by using the token value for the text label color in disabled and secondary states. Moreover, the validation pattern and auto-validation for wsproxy address input have been added to ensure correct URL format. ### How to test 1. go to resources - resource group tab 2. click the setting icon 3. check validation of the wsproxy address. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [x] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [x] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
agatha197
force-pushed
the
feature/wsproxy-address-validation
branch
from
40046ac
to
163dbb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2597
This pull request addresses a cosmetic issue by fixing a typo in the variable naming convention for resourceGroupWSProxyAddressInput. It also includes enhancements to the styling of the input fields by using the token value for the text label color in disabled and secondary states. Moreover, the validation pattern and auto-validation for wsproxy address input have been added to ensure correct URL format.
How to test
Checklist: (if applicable)